This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,testsuite] add powerpc_spe_ok effective target
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, janis187 at us dot bim dot com
- Date: Tue, 13 Jan 2009 11:26:33 -0800
- Subject: Re: [PATCH,testsuite] add powerpc_spe_ok effective target
- References: <20090113190028.GK28711@codesourcery.com>
- Reply-to: janis187 at us dot ibm dot com
On Tue, 2009-01-13 at 11:00 -0800, Nathan Froyd wrote:
> If we have a multilib that already specifies -mcpu=, then some of the
> SPE-related tests in the testsuite lead to errors, because the multilib
> -mcpu= is incompatible with the dg-options -mcpu=. Fixed by adding an
> effective target powerpc_spe_ok and using it where appropriate.
>
> Tested on powerpc-none-eabi{,spe}. OK to commit?
>
> -Nathan
>
> 2009-01-13 Daniel Jacobowitz <dan@codesourcery.com>
> Joseph Myers <joseph@codesourcery.com>
>
> * lib/target-supports.exp (check_effective_target_powerpc_spe_ok):
> New function.
> * gcc.target/powerpc/20030218-1.c: Use powerpc_spe_ok and consistent
> CFLAGS.
> * gcc.target/powerpc/20030505.c: Likewise.
> * gcc.target/powerpc/20081204-1.c: Likewise.
> * gcc.target/powerpc/ppc-spe.c: Likewise.
> * gcc.target/powerpc/spe1.c: Likewise.
> * g++.dg/other/opaque-2.C: Likewise.
> * g++.dg/other/opaque-3.C: Likewise.
Instead of doing it this way, look at Joel Sherrill's recent patch
http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00470.html and follow that
model instead: use powerpc-spe-nocache for the effective-target keyword
and call the nocache version of check_no_compiler_messages with
[current_compiler_flags] instead of the specific list, and use
dg-skip-if after dg-options.
Let me know if you think your version is still better.
Janis