This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR fortran/38507] Fix checks for valid GOTOs


Steve Kargl wrote:
On Sat, Jan 03, 2009 at 06:20:31PM +0100, Paul Richard Thomas wrote:
Dear Tobi,
Built and tested on i686-darwin. Ok?
Yes indeed - it's OK by me.  This raises the question as to whether we
should wait for 4.5?  I guess that we could cite a virtual regression?


Well, it fixes a fairly bad bug. It may also fix a regression,
but someone would need to check gfortran prior to Tobi's original bitmap implementation of tracking labels.

Well, I know that the patch which introduced bitmaps (which was intended to be only a performance patch) reversed the logic from right to wrong. The patch for PR17708 already introduced a wrong warning in 2004.


For the record, I don't think it's a bad bug, just a wrong warning, but the patch comes at low risk (at worst replacing a wrong warning by another wrong warning), but I'll leave it up to your to discretion whether to apply or not.

Cheers,
- Tobi



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]