This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix useless_type_conversion_p with incomplete types (PR middle-end/38505)

From: "Richard Guenther" <richard dot guenther at gmail dot com>
To: "Ian Lance Taylor" <iant at google dot com>
Cc: "Jakub Jelinek" <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 29 Dec 2008 17:21:43 +0100
Subject: Re: [PATCH] Fix useless_type_conversion_p with incomplete types (PR middle-end/38505)
References: <20081212215849.GK17496@tyan-ft48-01.lab.bos.redhat.com> <20081215115406.GM17496@tyan-ft48-01.lab.bos.redhat.com> <m3prjq95bg.fsf@google.com>

On Wed, Dec 17, 2008 at 4:42 PM, Ian Lance Taylor <iant@google.com> wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
>
>> 2008-12-15  Jakub Jelinek  <jakub@redhat.com>
>>
>>       PR middle-end/38505
>>       * tree-ssa.c (useless_type_conversion_p_1): Return
>>       false if inner_type is incomplete and outer_type is complete.
>>
>>       * gcc.c-torture/compile/pr38505.c: New test.
>
> This is OK.

I think the other patch is better.  The important difference is only if we
de-reference a pointer type.

Richard.

> Thanks.
>
> Ian
>

Follow-Ups:
- Re: [PATCH] Fix useless_type_conversion_p with incomplete types (PR middle-end/38505)
  - From: Jakub Jelinek

References:
- [PATCH] Fix may_propagate_address_into_dereference (PR middle-end/38505)
  - From: Jakub Jelinek
- [PATCH] Fix useless_type_conversion_p with incomplete types (PR middle-end/38505)
  - From: Jakub Jelinek
- Re: [PATCH] Fix useless_type_conversion_p with incomplete types (PR middle-end/38505)
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]