Re: PING: Missing TRULY_NOOP_TRUNCATION after restored optimize_bit_field_compare

[Richard Sandiford <rdsandiford at googlemail dot com>]

Adam Nemet <anemet@caviumnetworks.com> writes:
> Sorry about pinging this only after one week but I'm leaving for two weeks on
> Saturday and I'd like to commit this before.
>
> It requires a middle-end maintainer and a MIPS maintainer for the new test.
>
>   http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00766.html

Sorry, I didn't realise you wanted MIPS sign-off on the test.  Looks fine,
although I think the assembler tests are subtle enough to deserve a comment.
Something like:

/* When inserting something into the top bit of a 32-bit structure,
   we must make sure that the register remains properly sign-extended.
   There are two ways of doing this:

     - use purely 32-bit bit manipulations (a single INS, matched twice here).
     - use a 64-bit bit manipulation (DINS), but sign-extend the inserted
       field first.  We check for this extension using SLL.  */

After the testsuite changes I just committed:

  /* { dg-mips-options "-O -meb -mips64r2 -mgp64" } */

should be changed to:

  /* { dg-options "-O -meb isa_rev>=2 -mgp64"

Richard