This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping (i386 backend, configury)
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Alexandre Oliva <aoliva at redhat dot com>, David Edelsohn <dje at watson dot ibm dot com>
- Date: Thu, 18 Dec 2008 09:29:28 +0100
- Subject: Re: Patch ping (i386 backend, configury)
- References: <20081218080750.GU17496@tyan-ft48-01.lab.bos.redhat.com>
> [configury] http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00727.html
> P1 PR bootstrap/37739
> Fix powerpc*-linux 32-bit bootstrap where cc1* etc. grow
> too large for default 32-bit link if not -O1+ or -Wl,--relax
Just two nits:
> + if test x${GCC} = xyes \
> + && echo $CC | ${CC} -E -dD -xc - \
> + | grep '__SIZEOF_LONG__[ ][ ]*4' > /dev/null; then
ac_cv_sizeof_long should be already set here, so instead of forking $CC
and grep you can do this
if test "${GCC}:${ac_cv_sizeof_long}" = yes:4; then
> +ifeq ($(filter-out -O0,$(filter -O%,$(CFLAGS))),)
More easily understood and more precise if written as:
ifeq ($(lastword $(filter -O%,$(CFLAGS))),-O0)
I wouldn't actually oppose always compiling stage1 at -O1; the topic has
been raised many times. Maybe for 4.5.
Paolo