This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR 37469 invalid GMP usage on gfortran.dg/parameter_array_init_3.f90

From: Mikael Morin <mikael dot morin at tele2 dot fr>
To: correctifs gcc <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
Date: Tue, 09 Dec 2008 19:58:54 +0100
Subject: Re: [Patch, fortran] PR 37469 invalid GMP usage on gfortran.dg/parameter_array_init_3.f90
References: <493EBBF8.7070601@tele2.fr>

Mikael Morin wrote:
> Hi,
> 
> this patch solves a problem where find_array_element in expr.c was
> making some operations with GMP on non-constant expressions.
> 
> The patch adds calls to gfc_reduce_init_expr to simplify the array
> bounds before the operations. There is no testcase
> (parameter_array_init_3.f90 is already on trunk), but the added
> gcc_assert should prevent regressions in the future.
> 
> no regression on x86_64-unknown-linux-gnu.
> 
> Ok for trunk ?

Self reviewing:
it's better to cleanup on failure.
patch updated

Attachment: pr37469_03.diff
Description: Text document

Follow-Ups:
- Re: [Patch, fortran] PR 37469 invalid GMP usage on gfortran.dg/parameter_array_init_3.f90
  - From: Tobias Burnus

References:
- [Patch, fortran] PR 37469 invalid GMP usage on gfortran.dg/parameter_array_init_3.f90
  - From: Mikael Morin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]