This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR fortran/37779: Diagnose missing RECURSIVE, part 2


Daniel Kraft wrote:
> I did refactor and clean-up recursive-ness detection in resolve.c a
> bit, and hope I did get it all right (the ENTRY handling, too).  No
> regressions on GNU/Linux-x86-32.
> Ok for trunk (4.4)?  Or should we wait even with this patch for 4.5? 
> I believe this is enough of a bug-fix to go in for 4.4, though.
I think that should be OK for 4.4.

I think it does not really matter but the error message text for the
following example is not quite right since "test" is not an ENTRY:

subroutine tesT()
entry test2
  call test()
end subroutine test
end


  call test()
            1
Error: ENTRY 'test' at (1) cannot be called recursively, as subroutine
'test' is not RECURSIVE

As the message is still comprehensive and it is the same message as
before, I think one can leave it as is.

Thanks for the patch.

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]