This is the mail archive of the
mailing list for the GCC project.
Re: Patch to fix gcc.c-torture/compile/20010102-1.c on IA64 HP-UX
On Thu, 2008-11-27 at 12:16 -0700, Jeff Law wrote:
> Luis Machado wrote:
> > Hi,
> > The attached patch changes the handling of LO_SUM in "find_base_term" to
> > what "find_base_value" does.
> > No additional testsuite failures were noticed and SPEC2K numbers are
> > stable. Vortex 32-bit (that had degraded due to this problem) is back to
> > normal (up 3%) on PPC.
> > OK for mainline?
> It's fine. Can you also create a new PR and link it to the 4.5 pending
> patches meta-PR? For 4.5 I think we want to use a combination of the
> two approaches (short-circuit lo-sum and not return null so easily when
> the recursive calls return NULL).
Sure, i'll add the PR.
Wouldn't it be best to combine both approaches now?