This is the mail archive of the
mailing list for the GCC project.
Re: [patch]: Fix some corner cases in get_callee_fn and aggregate_value_p
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: "Kai Tietz" <Kai dot Tietz at onevision dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 26 Nov 2008 10:39:17 +0100
- Subject: Re: [patch]: Fix some corner cases in get_callee_fn and aggregate_value_p
- References: <OFD8F7932B.1860D3BA-ONC125750D.002E5BBC-C125750D.002F3FFC@onevision.de>
On Wed, Nov 26, 2008 at 9:36 AM, Kai Tietz <Kai.Tietz@onevision.com> wrote:
> while reviewing the call abi patch for x86_64, I found the following
> issues. Maybe they are of some relevants as I noticed they are happening.
> The patch in get_callee_fn for allowing check for addr being a
> FUNCTION_DECL seems to be of not much relevant here, but at least there is
> a check in front checking for
> a readonly function pointer, which verifies that TREE_CODE(addr) isn't
> already a FUNCTION_DECL.
The function.c part makes sense, but I don't see how what the tree.c
part tests for is valid - did that really happen? Testcase?
You didn't state if/how you bootstrapped and tested this.
> 2008-11-26 Kai Tietz <firstname.lastname@example.org>
> * tree.c (get_callee_fn): Allow that CALL_EXPR points directly to
> a FUNCTION_DECL.
> * function.c (aggregate_value_p): For call expression take
> function type itself, if there
> is no declaration available.
> Is this patch ok for apply?
> | (\_/) This is Bunny. Copy and paste Bunny
> | (='.'=) into your signature to help him gain
> | (")_(") world domination.