This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] default_format_denormal_1.f90: XFAIL on subversions


On Mon, Nov 24, 2008 at 10:06:10AM -0800, Janis Johnson wrote:
> On Sun, 2008-11-23 at 11:28 -0500, Jack Howarth wrote:
> > The attached patch allows the gfortran.dg/default_format_denormal_1.f90
> > to XFAIL on darwin8 and darwin9 with subversions but not on darwin10
> > and above. Tested on i686-apple-darwin10. Okay for gcc trunk?
> >              Jack
> > 
> > 2008-11-23  Jack Howarth  <howarth@bromo.med.uc.edu>
> > 
> > 	* gfortran.dg/default_format_denormal_1.f90: XFAIL on darwin8
> > 	and darwin9 subversions.
> 
> OK.  I checked it in for you, as requested offline.
> 
> Janis

Janis,
   Thanks for the commit, but you seemed to have stripped off the 
trailing * of *-*-darwin[89]*. Could you check in the correction...

Index: gcc/testsuite/gfortran.dg/default_format_denormal_1.f90
===================================================================
--- gcc/testsuite/gfortran.dg/default_format_denormal_1.f90     (revision 142191)
+++ gcc/testsuite/gfortran.dg/default_format_denormal_1.f90     (working copy)
@@ -1,4 +1,4 @@
-! { dg-do run { xfail *-*-darwin[89] *-*-freebsd* *-*-mingw* } }
+! { dg-do run { xfail *-*-darwin[89]* *-*-freebsd* *-*-mingw* } }
 ! Test XFAILed on these platforms because the system's printf() lacks
 ! proper support for denormals.
 !

Without the trailing *, we won't match targets like darwin8.5.0.
Thanks in advance.
                              Jack


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]