This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 38248 - don't silently fail if unlink/rename fails


On Tue, Nov 25, 2008 at 12:04:05AM +0100, Tobias Burnus wrote:
> Steve Kargl wrote:
> > On Mon, Nov 24, 2008 at 05:54:49PM +0100, Tobias Burnus wrote:
> >   
> >> +      if (unlink (filename))
> >> +	gfc_fatal_error ("Can't delete module file '%s': %s", filename,
> >>     
> > Why gfc_fatal_error instead of gfc_error or gfc_error_now?
> >   
> Frankly, I don't mind that much whether it is an error_now or a fatal
> error; however, I think gfc_fatal_error is OK since not able too write a
> file is rather bad and can lead to strange errors afterwards. (At least
> I often prefer to see the big error first without needing to dig through
> parenthesis diagnosts (due to changed .mod format) and other misleading
> error messages.)
> 
> But if you think gfc_error_now is superior, I can change it before
> submittal.
> 

I have no objection to gfc_fatal_error.  I was just curious,
because gfortran doesn't use gfc_fatal_error very often.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]