This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 24 Nov 2008 12:58:50 +0100
Subject: Re: [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC
References: <200811232201.06847.ebotcazou@adacore.com> <38a0d8450811240331u1906b06duf55cd34925fe1228@mail.gmail.com>

> I can't approve it, but it looks reasonably OK. Do you know why SPARC
> needs this special treatment?

The 'a' and 'c' operand modifiers are not (always) handled by output_operand, 
see output_asm_insn.

Any particular reason why you chose to mark symbols in output_operand and not 
in output_addr_const, where this seems to belong?

-- 
Eric Botcazou

Follow-Ups:
- Re: [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC
  - From: Rafael Espindola

References:
- [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC
  - From: Eric Botcazou
- Re: [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]