This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, libfortran] Fix PR 38234


Thomas Koenig wrote:
> this fixes another regression in RESHAPE bounds checking, which showed
> up with RUNTESTFLAGS="-target_board=unix/-fbounds-check", which
> Dominique then analyzed.
>
> Regression-tested both with and without the above flag (which I will
> start doing on a regular basis when doing bounds checking patches).
> OK for trunk?
>   
OK. Thanks to Dominique for spotting it and thanks to you for quickly
fixing it.
Doing regular checks with -fbounds-check is indeed a good idea (as are
-fdefault-*-8 runs, even though the latter will have more false positives).

Tobias

> 2008-11-23  Thomas Koenig  <tkoenig@gcc.gnu.org>
>
> 	PR libfortran/38234
> 	* intrinsics/reshape_generic.c (reshape_internal):
> 	Source can be larger than shape.
> 	* m4/reshape.m4:  Likewise.
> 	* generated/reshape_c10.c Regenerated.
> 	* generated/reshape_c16.c Regenerated.
> 	* generated/reshape_c4.c Regenerated.
> 	* generated/reshape_c8.c Regenerated.
> 	* generated/reshape_i16.c Regenerated.
> 	* generated/reshape_i4.c Regenerated.
> 	* generated/reshape_i8.c Regenerated.
> 	* generated/reshape_r10.c Regenerated.
> 	* generated/reshape_r16.c Regenerated.
> 	* generated/reshape_r4.c Regenerated.
> 	* generated/reshape_r8.c Regenerated.
>
> 2008-11-23  Thomas Koenig  <tkoenig@gcc.gnu.org>
>
> 	PR libfortran/38234
> 	* gfortran.dg/reshape_4.f90:  New test.
>
>   


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]