This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [LTO][PATCH] Fix lto1 ICE in pp_base_format
On Fri, Nov 21, 2008 at 11:25, Manuel LÃpez-IbÃÃez
<lopezibanez@gmail.com> wrote:
> 2008/11/21 Simon Baldwin <simonb@google.com>:
>> This patch fixes a compiler error that can occur in lto1 where a backend
>> diagnostic message contains a %E formatter. Without the patch lto1 fails
>> at pretty-print.c:559, for example:
>>
>> +/* Called during diagnostic message formatting process to print a
>> + source-level entity onto BUFFER. This is a slightly extended version
>> + of default_tree_printer() from toplev.c, and adds support for the '%E'
>> + for error messages printed by backends. */
>> +
>
> So why not extend default_tree_printer() instead of duplicating all this code?
That's an alternative, but we may want to grow more formatters
specific for gimple. It's true that this is a latent bug for every
other front-end that doesn't implement '%E'.
It's also not clear exactly what format strings are required to be
supported by every FE. I presume we don't have such a thing?
Diego.