This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [LTO][PATCH] Fix DECL merging problem due to incomplete types.


On Wed, Nov 19, 2008 at 18:42, Doug Kwan (éæå) <dougkwan@google.com> wrote:

>        * lto-symtab.c (external_aggregate_decl_p): New.
>        (lto_symtab_compatible): Handle external aggregate declarations
>        specially.
>
> testsuite/ChangeLog.lto
>
>        * g++.dg/lto/20081119-1.h: New.
>        * g++.dg/lto/20081119-1_0.C: New.
>        * g++.dg/lto/20081119-1_1.C: New.

OK with

> +/* Helepr for lto_symtab_compatible. Return TRUE if DECL is an external

s/Helepr/Helper/

> +	 There is no way a compiler can tell the size of x.  So we cannot
> +	 assume that external aggreates have complete types.
> +      */

Closing comment in previous line.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]