This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] RFC: PR fortran/37779, diagnose "missing" recursive


Mikael Morin wrote:
Daniel Kraft wrote:
Hi all,

yet another revised patch... This simply removes the "return FAILURE;"
spotted by Thomas and updates the recursive_check_4.f03 test so it would
have failed for this error.  I believe it is "better" now.
Hi,

If it doesn't return FAILURE, such constructs are useless?

+	  if (resolve_procedure_expression (e) == FAILURE)
+	    return FAILURE;


Actually, they are, but I somehow believe it does not harm to have it that way for future extensions or if we decide that certain situations should really result in an error; otherwise we should also change the return type to void. I'm happy with both versions, though.


Daniel

--
Done:  Arc-Bar-Cav-Rog-Sam-Val-Wiz
To go: Hea-Kni-Mon-Pri-Ran-Tou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]