This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4, middle end]: Fix PR 37908, thinko with atomic NAND operation


Uros Bizjak wrote:

> No, as explained in my previous message, it only matched wrong example.
>> +@emph{Note:} GCC 4.4 and later implement @code{__sync_nand_and_fetch}
>>
>> __sync_fetch_and_nand, right?
>>   
> We have two types of sync builtins - __sync_op_and_fetch and
> __sync_fetch_and_op. This one is correct.
> 
> Attached patch revision implements suggested once-per-file warning about
> changed NAND builtin semantics.

The patch wasn't attached.

However, given the explanations that have been provided, I think this is
the right thing to do, so I retract my original concern about changing
the meaning of the existing builtins.  If the new note provides a hint
about how to disable the note, then the patch is OK.

thansk,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]