This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] [gcc,g++].dg/compat/struct-layout-1_generate.c: Don't use -fno-common on darwin


The following patch eliminates the use of -fno-common on both the gcc.dg
and g++.dg struct-layout-1 tests for darwin. This eliminates the recent failure
of...

FAIL: tmpdir-g++.dg-struct-layout-1/t026 cp_compat_x_tst.o-cp_compat_y_tst.o execute 

that appeared after...

------------------------------------------------------------------------
r141825 | uros | 2008-11-13 13:34:05 -0500 (Thu, 13 Nov 2008) | 6 lines

        * gcc.dg/compat/struct-layout-1_generate.c (dg-options): Add -mno-mmx
        for i?86-*-* and x86_64-*-* targets
        * g++.dg/compat/struct-layout-1_generate.c (dg-options): Add
        -fno-common for *-*-darwin* *-*-mingw32* *-*-cygwin* targets.

This discovery led me to try removing -fno-common from the gcc.dg
struct-layout-1 tests as well which eliminated the failure...

FAIL: tmpdir-gcc.dg-struct-layout-1/t027 c_compat_x_tst.o-c_compat_y_tst.o execute

Now all of the tests pass...

Test Run By root on Sat Nov 15 01:24:18 2008
Native configuration is i686-apple-darwin9

		=== g++ tests ===

Schedule of variations:
    unix

Running target unix
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using /sw/src/fink.build/gcc44-4.3.999-20081114/gcc-4.4-20081114/gcc/testsuite/config/default.exp as tool-and-target-specific interface file.
Running /sw/src/fink.build/gcc44-4.3.999-20081114/gcc-4.4-20081114/gcc/testsuite/g++.dg/compat/struct-layout-1.exp ...

		=== g++ Summary ===

# of expected passes		150
/sw/src/fink.build/gcc44-4.3.999-20081114/darwin_objdir/gcc/testsuite/g++/../../g++  version 4.4.0 20081114 (experimental) (GCC) 

Test Run By root on Sat Nov 15 01:36:12 2008
Native configuration is i686-apple-darwin9

		=== gcc tests ===

Schedule of variations:
    unix

Running target unix
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using /sw/src/fink.build/gcc44-4.3.999-20081114/gcc-4.4-20081114/gcc/testsuite/config/default.exp as tool-and-target-specific interface file.
Running /sw/src/fink.build/gcc44-4.3.999-20081114/gcc-4.4-20081114/gcc/testsuite/gcc.dg/compat/struct-layout-1.exp ...

		=== gcc Summary ===

# of expected passes		140
/sw/src/fink.build/gcc44-4.3.999-20081114/darwin_objdir/gcc/xgcc  version 4.4.0 20081114 (experimental) (GCC) 

Okay for gcc trunk?
             Jack


2008-11-14  Jack Howarth  <howarth@bromo.med.uc.edu>
        
        PR testsuite/38099
        * gcc.dg/compat/struct-layout-1_generate.c: Don't use -fno-common on darwin.
	* g++.dg/compat/struct-layout-1_generate.c: Same.


Index: gcc/testsuite/gcc.dg/compat/struct-layout-1_generate.c
===================================================================
--- gcc/testsuite/gcc.dg/compat/struct-layout-1_generate.c	(revision 141878)
+++ gcc/testsuite/gcc.dg/compat/struct-layout-1_generate.c	(working copy)
@@ -45,7 +45,7 @@
 const char *dg_options[] = {
 "/* { dg-options \"%s-I%s\" } */\n",
 "/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
-"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
+"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-mingw32* *-*-cygwin* } } */\n",
 "/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
 "/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"
 #define NDG_OPTIONS (sizeof (dg_options) / sizeof (dg_options[0]))
Index: gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c
===================================================================
--- gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c	(revision 141878)
+++ gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c	(working copy)
@@ -45,7 +45,7 @@
 const char *dg_options[] = {
 "/* { dg-options \"%s-I%s\" } */\n",
 "/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
-"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
+"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-mingw32* *-*-cygwin* } } */\n",
 "/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
 "/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"
 #define NDG_OPTIONS (sizeof (dg_options) / sizeof (dg_options[0]))


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]