This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite]: Synchronize dg-options in {gcc,g++}.dg/compat/struct-layout-1_generate.c


On Thu, Nov 13, 2008 at 07:34:36PM +0100, Uros Bizjak wrote:
> Hello!
>
> This patch synchronizes dg-options array in  
> {gcc,g++}.dg/compat/struct-layout-1_generate.c.
>
> The patch fixes at least
>
> Running target unix
> FAIL: tmpdir-gcc.dg-struct-layout-1/t027  
> c_compat_x_tst.o-c_compat_y_tst.o execute
>
> 2008-11-13  Uros Bizjak  <ubizjak@gmail.com>
>
>    * gcc.dg/compat/struct-layout-1_generate.c (dg-options): Add -mno-mmx
>    for i?86-*-* and x86_64-*-* targets
>    * g++.dg/compat/struct-layout-1_generate.c (dg-options): Add
>    -fno-common for *-*-darwin* *-*-mingw32* *-*-cygwin* targets.
>
>
> Patch was tested on x86_64-pc-linux-gnu {,-m32}, committed to mainline  
> as obvious.
>
> Uros.

> Index: g++.dg/compat/struct-layout-1_generate.c
> ===================================================================
> --- g++.dg/compat/struct-layout-1_generate.c	(revision 141824)
> +++ g++.dg/compat/struct-layout-1_generate.c	(working copy)
> @@ -45,7 +45,7 @@ along with GCC; see the file COPYING3.  
>  const char *dg_options[] = {
>  "/* { dg-options \"%s-I%s\" } */\n",
>  "/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
> -"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* } } */\n",
> +"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
>  "/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
>  "/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"
>  #define NDG_OPTIONS (sizeof (dg_options) / sizeof (dg_options[0]))
> Index: gcc.dg/compat/struct-layout-1_generate.c
> ===================================================================
> --- gcc.dg/compat/struct-layout-1_generate.c	(revision 141824)
> +++ gcc.dg/compat/struct-layout-1_generate.c	(working copy)
> @@ -44,6 +44,7 @@ along with GCC; see the file COPYING3.  
>  
>  const char *dg_options[] = {
>  "/* { dg-options \"%s-I%s\" } */\n",
> +"/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
>  "/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
>  "/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
>  "/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"

The change to g++.dg/compat/struct-layout-1_generate.c has created a regression in
the g++ testsuite on i686-apple-darwin9 where none existed before. Now I see...

Running /sw/src/fink.build/gcc44-4.3.999-20081114/gcc-4.4-20081114/gcc/testsuite/g++.dg/compat/struct-layout-1.exp ...
FAIL: tmpdir-g++.dg-struct-layout-1/t026 cp_compat_x_tst.o-cp_compat_y_tst.o execute 

whereas before that change there were no failures.
                 Jack


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]