This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for PR libgomp/37938, IA64 specific.


On Thu, Nov 13, 2008 at 09:54:19AM -0800, Steve Ellcey wrote:
> OK, here is the patch I tested last night.  It fixes the bug and caused
> no regressions.  The only difference between this mutex.h and the regular
> one is the call to __sync_synchronize in gomp_mutex_unlock.  Should I go
> ahead and check it in?

Yes please.  Just minor comments inline.

> 2008-11-13  Steve Ellcey  <sje@cup.hp.com>
> 

Add here:
	PR libgomp/37938
> 	* config/linux/ia64/mutex.h: New.

> --- config/linux/ia64/mutex.h	(revision 0)
> +++ config/linux/ia64/mutex.h	(revision 0)
> @@ -0,0 +1,68 @@
> +/* Copyright (C) 2005 Free Software Foundation, Inc.

And here `, 2008'.

> +/* IA64 needs a __sync_synchronize call before  __sync_lock_test_and_set
> +   because  __sync_lock_test_and_set is not a full memory fence.  */

Why 2 spaces between __sync?  One should be enough.  Also, shouldn't
there be a comma before because?

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]