This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix small structure passing on x86-64
On Tue, 11 Nov 2008, H.J. Lu wrote:
> >> This is OK for mainline and all release branches after a couple of
> >> days in mainline without problems.
> > Please do not put this onto the active branches. We're not yet sure
> > the patch is correct.
> FWIW, that is what icc does. Gcc was wrong.
There's no argument that GCC was wrong, and what should happen instead.
The problem is to be sure that the patch does what it intended. Small
structs could now be copied with a movq which might be a problem if they
are unaligned (not just containing unaligned fields).