This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin*


On Tue, Nov 11, 2008 at 10:31:37AM -0500, Jack Howarth wrote:
> The attached patch skips the gcc.dg/visibility-1[4-9].c testcases
> on *-apple-darwin* as recommended in comment 4 of PR37202. Tested
> on i686-apple-darwin9. Okay for gcc trunk?
>                       Jack
> 
> 2008-11-11  Jack Howarth  <howarth@bromo.med.uc.edu>
>         
>         PR testsuite/37202
>         * gcc.dg/visibility-14.c:  Skip on *-apple-darwin*.
> 	* gcc.dg/visibility-15.c:  Same.
> 	* gcc.dg/visibility-16.c:  Same.
> 	* gcc.dg/visibility-17.c:  Same.
> 	* gcc.dg/visibility-18.c:  Same.
> 	* gcc.dg/visibility-19.c:  Same.
> 
> Index: gcc/testsuite/gcc.dg/visibility-15.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-15.c	(revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-15.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* Test that accessed external functions are marked. */
>  /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
>  /* { dg-require-visibility "" } */
>  /* { dg-final { scan-hidden "foo" } } */
>  
> Index: gcc/testsuite/gcc.dg/visibility-17.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-17.c	(revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-17.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* Test that external variable whose address is taken are marked. */
>  /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
>  /* { dg-require-visibility "" } */
>  /* { dg-final { scan-hidden "foo" } } */
>  
> Index: gcc/testsuite/gcc.dg/visibility-19.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-19.c	(revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-19.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* Test that accessed external functions are marked. */
>  /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
>  /* { dg-require-visibility "" } */
>  /* { dg-final { scan-hidden "foo" } } */
>  
> Index: gcc/testsuite/gcc.dg/visibility-14.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-14.c	(revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-14.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* Test that called external functions are marked. */
>  /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
>  /* { dg-require-visibility "" } */
>  /* { dg-final { scan-hidden "foo" } } */
>  
> Index: gcc/testsuite/gcc.dg/visibility-16.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-16.c	(revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-16.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* Test that accessed external variables are marked. */
>  /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
>  /* { dg-require-visibility "" } */
>  /* { dg-final { scan-hidden "foo" } } */
>  
> Index: gcc/testsuite/gcc.dg/visibility-18.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-18.c	(revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-18.c	(working copy)
> @@ -1,5 +1,6 @@
>  /* Test that external variable whose address is taken are marked. */
>  /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
>  /* { dg-require-visibility "" } */
>  /* { dg-final { scan-hidden "foo" } } */
>  

A minor correction to the ChangeLog entry. It should really read...

 2008-11-11  Jack Howarth  <howarth@bromo.med.uc.edu>

	PR testsuite/37202
	* gcc.dg/visibility-14.c:  Skip on *-*-darwin*.
	* gcc.dg/visibility-15.c:  Same.
	* gcc.dg/visibility-16.c:  Same.
	* gcc.dg/visibility-17.c:  Same.
	* gcc.dg/visibility-18.c:  Same.
	* gcc.dg/visibility-19.c:  Same.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]