This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix up COMPLEX_EXPR pretty-printing (PR c++/35334)


2008/11/11 Jakub Jelinek <jakub@redhat.com>:
> On Tue, Nov 11, 2008 at 03:09:00PM +0100, Manuel López-Ibáñez wrote:
>> These testcases (and the C++ ones) would work with or without your
>> patch, wouldn't they?
>
> That's true, but it is something that has been done for all the
> "not supported by" testcases I remember during last few years.
> I don't think we should match the exact spelling of the diagnostics,
> that keeps changing over time.  Perhaps just ensure
> "not supported by" isn't matched on any line.

I am of the opinion that changes of spelling are easily updated with a
bit of regexp magic and such precise testcases allow to detect
duplicated testcases and subtler bugs. But I know the general opinion
is different. So I guess that ensuring that the not supported isn't
matched would be enough.

Cheers,

Manuel.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]