This is the mail archive of the
mailing list for the GCC project.
Re: [PING^3] Make ARM use UNSPECs instead of complicated CONSTs
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, nickc at redhat dot com, paul at codesourcery dot com
- Date: Sat, 08 Nov 2008 09:44:47 +0000
- Subject: Re: [PING^3] Make ARM use UNSPECs instead of complicated CONSTs
- References: <email@example.com> <20081104214033.GB30736@hungry-tiger.westford.ibm.com>
Thanks for taking a look.
Michael Meissner <firstname.lastname@example.org> writes:
> On Tue, Oct 28, 2008 at 10:30:08PM +0000, Richard Sandiford wrote:
>> Fixes what I think is the last example of (const minus) being used
>> by a port. Please review, since the fix for PR37363 depends on it.
> I took a look at this, and I wonder why you don't see an insn not
> found message for the change in arm.c to build the pic_rtx register
> with UNSPEC_GOTSYM_OFF, since I don't see any insns that use
The idea is that the UNSPEC_GOTSYM_OFF is wrapped in a CONST, just like
the original MINUS expression was. Both the old and new forms satisfy
immediate_operand, so the SET matches the normal move insns.
As it happens, Paul recently approved the patch in the original thread
(thanks) so I've since applied it. But like I say, thanks for looking
at the patch, and for raising your concerns.