This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto][patch] Split all_lto_ipa_passes out of all_regular_ipa_passes


On Thu, Nov 6, 2008 at 10:44, Rafael Espindola <espindola@google.com> wrote:

> @@ -1248,7 +1248,14 @@ ipa_passes (void)
>    gimple_register_cfg_hooks ();
>    bitmap_obstack_initialize (NULL);
>    execute_ipa_pass_list (all_small_ipa_passes);
> -  execute_regular_ipa_pass_list (all_regular_ipa_passes);
> +
> +  execute_ipa_summary_passes ((struct ipa_opt_pass *) all_regular_ipa_passes);
> +  execute_ipa_summary_passes ((struct ipa_opt_pass *) all_lto_ipa_passes);

None of the LTO generation passes has a summary generation phase.
But I guess that conceptually they could, so this is OK.

>  /* The root of the compilation pass tree, once constructed.  */
>  struct opt_pass *all_passes, *all_small_ipa_passes, *all_lowering_passes,
> -  *all_regular_ipa_passes;
> +  *all_regular_ipa_passes, *all_lto_ipa_passes;

I would rather name this all_lto_gen_passes or something like
that.  These passes simply write out LTO information.

> +  *p = NULL;
> +
> +  p = &all_lto_ipa_passes;
> +  NEXT_PASS (pass_ipa_lto_gimple_out);
> +  NEXT_PASS (pass_ipa_lto_cgraph);
>    NEXT_PASS (pass_ipa_lto_wpa_fixup);
> -  NEXT_PASS (pass_ipa_lto_finish_out);  /* This must be the last IPA_PASS.  */
> +  NEXT_PASS (pass_ipa_lto_finish_out);

Leave the comment in, please.  pass_ipa_lto_finish_out still
must be the last LTO generation pass.


OK with those changes.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]