This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix FAIL of gcc.target/sparc/pdist-3.c (PR 35574) (Take 3)

From: Eric Botcazou <ebotcazou at adacore dot com>
To: David Miller <davem at davemloft dot net>
Cc: gcc-patches at gcc dot gnu dot org, kazu at codesourcery dot com, rth at redhat dot com, jakub at redhat dot com
Date: Thu, 6 Nov 2008 08:41:38 +0100
Subject: Re: [patch] Fix FAIL of gcc.target/sparc/pdist-3.c (PR 35574) (Take 3)
References: <20081105144551.97C736F6218E@daisy.codesourcery.com> <20081105.150702.208350572.davem@davemloft.net>

> > Tested on sparc.  OK to apply to 4.3 and mainline?
>
> This patch looks good to me.

Agreed, except for 2 things: the new const_double_or_vector_operand predicate 
should be added to the "Predicates for numerical constants" section of the 
predicates.md file and not at the end; and a minor nit:

Index: gcc/config/sparc/sparc.h
===================================================================
--- gcc/config/sparc/sparc.h    (revision 226562)
+++ gcc/config/sparc/sparc.h    (working copy)
@@ -1870,6 +1870,8 @@ do {                                                                      
\
 
 /* Optional extra constraints for this machine.
 
+   'D' handles the const_vector.


'D' handles vector constants.

-- 
Eric Botcazou

References:
- [patch] Fix FAIL of gcc.target/sparc/pdist-3.c (PR 35574) (Take 3)
  - From: Kazu Hirata
- Re: [patch] Fix FAIL of gcc.target/sparc/pdist-3.c (PR 35574) (Take 3)
  - From: David Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]