This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fwd: Re: [Patch, Fortran] PR fotran/35820 again: memory leak while resolving nested foralls.]
- From: Mikael Morin <mikael dot morin at tele2 dot fr>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: correctifs gcc <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Fri, 31 Oct 2008 17:40:04 +0100
- Subject: Re: [Fwd: Re: [Patch, Fortran] PR fotran/35820 again: memory leak while resolving nested foralls.]
- References: <490AFEFB.9030808@tele2.fr> <490B2763.4010105@tele2.fr> <490B2A0F.6060408@net-b.de>
Tobias Burnus wrote:
> Hi,
>
>> Committed as revision 141496.
>>
> Question: Was this actually reviewed by someone? (Note that you have
> only a "Write After Approval" account.*)
Well I saw this:
http://gcc.gnu.org/ml/fortran/2008-10/msg00205.html
as an approval.
However, it seems that Dominique is no maintainer, no "writer after
approval", no nothing.
So, no, it wasn't reviewed by anyone.
> Glancing at it, it looked OK, but someone should re-check; I wouldn't
> count this as obvious ;-)
Paul, where are you hiding? :)
>
> (Yes, I know that we currently have a reviewing problem - lagging behind
> with several patches.)
>
> Tobias
>
> * actually, also so-called "MAINTAINERS" have to seek approval: "Note
> that individuals who maintain parts of the compiler as non-algorithmic
> maintainers need approval to check in algorithmic changes or changes
> outside of the parts of the compiler they maintain."
> For write after approval, see: http://gcc.gnu.org/svnwrite.html#policies
>