Re: [PATCH] XFAIL -frtl-abstract-sequences tests on s390*-*-*

["Richard Guenther" <richard dot guenther at gmail dot com>]

On Fri, Oct 31, 2008 at 5:22 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> These tests ICE on s390*-*-* (similarly to almost all other platforms).
> Ok to XFAIL them?
>
> Alternatively, can we just remove -frtl-abstract-sequences option from 4.4+?
> This pass doesn't work on anything at all on most of the primary and
> secondary targets, and is broken there for more than 2.5 years.

Yes please.  I don't know if I can pre-approve a patch to remove it, but in case
I can, this is it ;)  Nowadays this feature should be implemented on
the tree level
and using the value-numbering infrastructure we have.  This could address
missing code-motion optimizations as well.

Thanks,
Richard.

> 2008-10-31  Jakub Jelinek  <jakub@redhat.com>
>
>        * gcc.c-torture/compile/pr11832.c: XFAIL even on s390*-*-*.
>        * gcc.c-torture/compile/pr33009.c: Likewise.
>
> --- gcc/testsuite/gcc.c-torture/compile/pr11832.c.jj4   2008-10-30 12:14:11.000000000 -0400
> +++ gcc/testsuite/gcc.c-torture/compile/pr11832.c       2008-10-31 12:05:08.000000000 -0400
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* Currently ICEs for IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
> -/* { dg-xfail-if "PR33642" { hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* } { "*" } { "" } } */
> +/* { dg-xfail-if "PR33642" { hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
>  /* Currently ICEs for (x86 && ilp32 && pic).  */
>  /* { dg-xfail-if "PR33642/36240" { { i?86-*-* x86_64-*-* } && { ilp32 && { ! nonpic } } } { "*" } { "" } } */
>  /* { dg-prune-output ".*internal compiler error.*" }
> --- gcc/testsuite/gcc.c-torture/compile/pr33009.c.jj4   2008-10-30 12:14:11.000000000 -0400
> +++ gcc/testsuite/gcc.c-torture/compile/pr33009.c       2008-10-31 12:05:29.000000000 -0400
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* Currently ICEs for IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
> -/* { dg-xfail-if "PR33642" { hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* } { "*" } { "" } } */
> +/* { dg-xfail-if "PR33642" { hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
>  /* Currently ICEs for (x86 && ilp32 && pic).  */
>  /* { dg-xfail-if "PR33642/36240" { { i?86-*-* x86_64-*-* } && { ilp32 && { ! nonpic } } } { "*" } { "" } } */
>  /* { dg-prune-output ".*internal compiler error.*" }
>
>        Jakub
>