This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libjava support for AIX

From: Andrew Haley <aph at redhat dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: David Edelsohn <dje dot gcc at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Java Patches <java-patches at gcc dot gnu dot org>
Date: Fri, 24 Oct 2008 09:45:43 +0100
Subject: Re: [PATCH] libjava support for AIX
References: <303e1d290810151652vcee0b93t50affde224baf2f2@mail.gmail.com> <m38wsfxed6.fsf@fleche.redhat.com>

Tom Tromey wrote:
>>>>>> "David" == David Edelsohn <dje.gcc@gmail.com> writes:
> 
> David> Index: classpath/native/fdlibm/fdlibm.h
>  
> David>  #include <config.h>
> David>  #include <stdlib.h>
> David> +#undef hz
>  
> Could you add a blank line between the #include and the #undef, and a
> comment explaining why this is needed?  Thanks.
> 
> This part should go into Classpath; I'll handle that.
> 
> David> +++ sysdep/powerpc/locks.h	(working copy)
> 
> I don't know enough to review this bit.  I'm inclined to take your
> word for it, though, unless Andrew wants to take a look.

It's kinda evil.  I guess the AIX assembler doesn't have local labels
(which were invented in 1958 by M.E. Conway for the UNIVAC 1 assembler.
Time to catch up, IBM!)

I suppose we'll live with it.

Andrew.

Follow-Ups:
- Re: [PATCH] libjava support for AIX
  - From: Jakub Jelinek

References:
- [PATCH] libjava support for AIX
  - From: David Edelsohn
- Re: [PATCH] libjava support for AIX
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]