This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [graphite] Add -fgraphite-identity
On Thu, Oct 23, 2008 at 10:56:11AM -0500, Sebastian Pop wrote:
> > * doc/invoke.texi: Add -fgraphite-identity.
> > +Enable the identity transformation for graphite. For every SCoP we generate
> > +the polyhedral representation and transform it back to gimple. Using
> > +-fgraphite-identity we can check the costs or benefits of the
> > +GIMPLE -> GRAPHITE -> GIMPLE transformation.
>
> Please remove this from the patch that you propose for mainline. Also
> please correct in the graphite branch the documentation formatting:
> "dot space space".
>
> > + /* Generate code, even if we did not apply any real transformation.
>
> s/Generate code, even/Generate code even/
> s/did not apply/did not applied/
>
> > + Keep in mind, that CLooG optimizes in control, so the loop structure
>
> s/Keep in mind, that/Keep in mind that/
>
>
> The patch looks good. Please apply after these corrections.
>
> Thanks,
> Sebastian
Sebastian,
Do you plan on moving the fix...
http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00902.html
into gcc trunk soon? Can that be applied by itself to trunk?
I ask because I ran into a bunch of these irreducible errors
while compiling pymol with -fgraphite.
Jack