This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [graphite] Add -fgraphite-identity
- From: "Sebastian Pop" <sebpop at gmail dot com>
- To: "Tobias Grosser" <grosser at fim dot uni-passau dot de>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 23 Oct 2008 10:56:11 -0500
- Subject: Re: [graphite] Add -fgraphite-identity
- References: <1223663206.1370.63.camel@localhost> <1224774591.1256.11.camel@localhost>
> * doc/invoke.texi: Add -fgraphite-identity.
> +Enable the identity transformation for graphite. For every SCoP we generate
> +the polyhedral representation and transform it back to gimple. Using
> +-fgraphite-identity we can check the costs or benefits of the
> +GIMPLE -> GRAPHITE -> GIMPLE transformation.
Please remove this from the patch that you propose for mainline. Also
please correct in the graphite branch the documentation formatting:
"dot space space".
> + /* Generate code, even if we did not apply any real transformation.
s/Generate code, even/Generate code even/
s/did not apply/did not applied/
> + Keep in mind, that CLooG optimizes in control, so the loop structure
s/Keep in mind, that/Keep in mind that/
The patch looks good. Please apply after these corrections.
Thanks,
Sebastian