Re: [PATCH]: Fix missed PRE optimization discovered

[Laurent GUERBY <laurent at guerby dot net>]

On Tue, 2008-10-21 at 15:55 +0200, Andreas Schwab wrote:
> Laurent GUERBY <laurent@guerby.net> writes:
> 
> > On Tue, 2008-10-21 at 15:47 +0200, Andreas Schwab wrote:
> >> Laurent GUERBY <laurent@guerby.net> writes:
> >> 
> >> > On Tue, 2008-10-21 at 15:12 +0200, Eric Botcazou wrote:
> >> >> Btw, do you know why you sometimes have a few ACATS failures in your report?
> >> >
> >> > Most of the time in the logs for these random fail I have a successful
> >> > gnatmake then when executing the test the executable file is not found.
> >> >
> >> > This happens less now that we have a sync
> >> > in /gcc/testsuite/ada/acats/run_all.sh:
> >> >
> >> >       if [ ! -x $dir/tests/$chapter/$i/$binmain ]; then
> >> >          sync
> >> 
> >> How can this sync create a file?
> >
> > The sync is there (in theory) just to help with gnatmake being
> > successfull but the executable file not being there yet:
> 
> If the file is not there then it has never been created, and a sync
> cannot change that.

I started to instrument the run_all.sh script, for the spurious
failures here:

http://gcc.gnu.org/ml/gcc-testresults/2008-10/msg01508.html

LAST_UPDATED: Tue Oct 21 19:42:39 UTC 2008 (revision 141275)

		=== acats tests ===
FAIL:	c48009d
FAIL:	cb20006

The content of the cb2006 test build directory just after the sync were:

total 100
-rw-r--r-- 1 guerby guerby 12035 2008-10-22 01:03 b~cb20006.adb
-rw-r--r-- 1 guerby guerby 18881 2008-10-22 01:03 b~cb20006.ads
-rw-r--r-- 1 guerby guerby  8083 2008-10-22 01:03 b~cb20006.ali
-rw-r--r-- 1 guerby guerby 15680 2008-10-22 01:03 b~cb20006.o
-rw-r--r-- 1 guerby guerby     0 2008-10-22 01:03 cb20006
-rw-r--r-- 1 guerby guerby  2498 2008-10-22 01:03 cb20006_0.adb
-rw-r--r-- 1 guerby guerby  2739 2008-10-22 01:03 cb20006_0.ads
-rw-r--r-- 1 guerby guerby  2384 2008-10-22 01:03 cb20006_0.ali
-rw-r--r-- 1 guerby guerby  8400 2008-10-22 01:03 cb20006_0.o
-rw-r--r-- 1 guerby guerby  2716 2008-10-22 01:03 cb20006.adb
-rw-r--r-- 1 guerby guerby  2381 2008-10-22 01:03 cb20006.ali
-rw-r--r-- 1 guerby guerby    12 2008-10-22 01:03 cb20006.lst
-rw-r--r-- 1 guerby guerby  5784 2008-10-22 01:03 cb20006.o

The "cb20006" file was there but empty and not executable hence the
failure and sync triggering. I don't know why the linker last called by
gnatmake left such a state.

The c47009d test failed spuriously too but did not trigger the sync
and so I've no detailed log.

Still investigating.

Laurent