This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;

From: "Manuel López-Ibáñez" <lopezibanez at gmail dot com>
To: "Mark Mitchell" <mark at codesourcery dot com>
Cc: "Gcc Patch List" <gcc-patches at gcc dot gnu dot org>
Date: Sun, 19 Oct 2008 16:00:19 +0200
Subject: Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;
References: <6c33472e0808261033j2fa7748ax81cf9e9a77380386@mail.gmail.com> <48B73A60.8050709@codesourcery.com>

2008/8/29 Mark Mitchell <mark@codesourcery.com>:
> Manuel López-Ibáñez wrote:
>
>> 2008-08-26  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
>>
>>       PR c++/37004
>> cp/
>
> The idea here is OK, but you need comments on every new function
> explaining each parameter, even if the original functions you're working
> from failed to conform to that requirement.  In particular,
> cp_common_type does not meet requirements.  Please resubmit with
> comments corrected.

Here is the update patch. The ChangeLog is the same as in the original.

Just in case, bootstrapped and regression tested on
x86_64-unknown-linux-gnu with
--enable-languages=all

OK to commit?

Cheers,

Manuel.

Attachment: fix-pr37004.diff
Description: Text document

Follow-Ups:
- Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]