This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Vartracking: Remove assertion in vt_add_function_parameters


Jakub Jelinek wrote:
> On Fri, Oct 17, 2008 at 03:00:01PM +0200, Andreas Krebbel wrote:
>> bootstrap of mainline GCC currently fails on s390x due to the
>> assertion in vt_add_function_parameters.
>>
> 
> This is PR37815 and while your patch lets it go on compiling,
> I'm not convinced it is right - we can't track the parameter (nor other
> stuff shared in the stack slot) in var-tracking.c anymore.
> I think either the PR37447 patch needs to be reverted, or we need to find
> some way how to still record the original decl+offset in the shared
> spill slot for var-tracking purposes.  Richard?

Anyway, this:

+      /* This might fail if reload spilled the parameter to the stack.
+	 In that case the DECL entry in the MEM_ATTRS will point to a
+	 fake decl (%sfp) shared by all spill slots.  */
+      if (decl == parm)
+	continue;

has to be "if (decl != parm)".

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]