This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch to shrink the size of df_refs.
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Kenneth Zadeck <zadeck at naturalbridge dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 11 Oct 2008 12:27:03 +0200
- Subject: Re: patch to shrink the size of df_refs.
- References: <48DAD6E4.80604@naturalbridge.com> <48DB3867.8050602@gnu.org> <48DB7C6A.9070102@naturalbridge.com> <48DE3E05.7020203@naturalbridge.com>
Just a couple of coding standards nits:
> + case DF_REF_REGULAR:
> + return DF_REF_LOC (ref1) == DF_REF_LOC (ref2);
> + }
> + gcc_unreachable ();
> + return false;
Either no return after gcc_unreachable, or place gcc_unreachable as a
"default" label in the previous switch statement.
> + if ((DF_REF_CLASS (ref1) != DF_REF_ARTIFICIAL)
> + && (DF_REF_LOC (ref1) != DF_REF_LOC (ref2)))
Redundant parentheses.
Otherwise ok.
Paolo