This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Bug middle-end/37448] patch to compute alloc-pool stats correctly


Kenneth Zadeck <zadeck@naturalbridge.com> writes:

> Ian Lance Taylor wrote:
>> Kenneth Zadeck <zadeck@naturalbridge.com> writes:
>>
>>   
>>>> I wonder if some of the types in alloc_pool_descriptor should be
>>>> size_t rather than int, though it's hard to imagine it making a
>>>> difference in real life.
>>>>
>>>>   
>>>>       
>>> I noticed this too, it actually does make a difference in the printing
>>> of the values on the testcase since they overflow.  However, I did not
>>> know how to modify the formats in the printfs to print the size_ts.
>>>     
>>
>> The simple way is to use "unsigned long" and "%lu".
>>
>> Ian
>>   
> do you want me to redo the patch with this change?

That change to the patch is preapproved if you want to do it.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]