This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [vta] revamp bootstrap-debug with -fcompare-debug, fix LIBCFLAGS uses
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 7 Oct 2008 10:36:00 +0200
- Subject: Re: [vta] revamp bootstrap-debug with -fcompare-debug, fix LIBCFLAGS uses
- References: <orr66sakgi.fsf@oliva.athome.lsd.ic.unicamp.br>
Hello Alexandre,
a couple of nits, if I may.
* Alexandre Oliva wrote on Tue, Oct 07, 2008 at 10:16:45AM CEST:
> for ChangeLog.vta
> from Alexandre Oliva <aoliva@redhat.com>
[...]
> * libjava/configure.ac: Insert libgcjdir in the GCJ passed in the
> environment, rather than overriding completely.
> * libjava/configure: Rebuilt.
Not in a separate ChangeLog file?
> --- libjava/configure.ac.orig 2008-10-03 15:38:23.000000000 -0300
> +++ libjava/configure.ac 2008-10-07 05:02:35.000000000 -0300
> @@ -352,23 +352,30 @@ else
> which_gcj=path
> fi
> fi
> +libgcjdir=`${PWDCMD-pwd}`
> +case $libgcjdir in
> +*,*) libgcjdir=`echo "$libgcjdir" | sed 's:,:\\,:g'`;;
> +esac
Why was this escaping added? It looks wrong. At least if it's supposed
to fix some missing escaping inside config.status then that's the wrong
way to go.
> +case $GCJ in
> +*" -B"*)
> + GCJ=`echo "$GCJ" | sed "s, -B, -B$libgcjdir/&,"`
> + ;;
> +*)
> + GCJ=$GCJ" -B$libgcjdir/"
> + ;;
> +esac
Cheers,
Ralf