This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Avoid spending exponential time in contain_placeholder_p()
- From: Ian Lance Taylor <iant at google dot com>
- To: Geert Bosch <bosch at adacore dot com>
- Cc: gcc-patches Patches <gcc-patches at gcc dot gnu dot org>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Tue, 30 Sep 2008 11:49:32 -0700
- Subject: Re: [PATCH] Avoid spending exponential time in contain_placeholder_p()
- References: <826E1CE9-07DD-415D-B5DF-02B3CE3E8173@adacore.com>
Geert Bosch <bosch@adacore.com> writes:
> 2008-09-29 Geert Bosch <bosch@adacore.com>
>
> * tree.c (contains_placeholder_p): Return 0 for a SAVE_EXPR
Period at end of sentence.
> + case SAVE_EXPR:
> + /* save_expr () never wraps anything containing a
> placeholder */
> + return 0;
Omit "()" in comment. In fact, better to write "The save_expr
function". Period at end of sentence.
OK with those changes if it passes bootstrap and testing (you didn't
say).
Thanks.
Ian