This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING C++] Move empty-if warning to the front-end
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 26 Sep 2008 23:27:03 -0400
- Subject: Re: [PING C++] Move empty-if warning to the front-end
- References: <ga52a1$tks$1@ger.gmane.org>
Paolo Bonzini wrote:
> This patch from stage1:
>
> http://permalink.gmane.org/gmane.comp.gcc.patches/170041
>
> needs C++ maintainer approval. It allows to avoid a hack in the removal
> of CONVERT_EXPR, by avoiding that NOP_EXPR<void>(0) and
> CONVERT_EXPR<void>(0) have different meaning.
This is conceptually OK. But, I would like to understand why you've
duplicate the code for both the if and else clauses, and also why that
code isn't exactly the same, other than the literal word "if" and "else".
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713