This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch to shrink the size of df_refs.
- From: Kenneth Zadeck <zadeck at naturalbridge dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Steven Bosscher <stevenb dot gcc at gmail dot com>, Seongbae Park <spark at google dot com>, "Hubicha, Jan" <jh at suse dot cz>, rdsandiford at googlemail dot com
- Date: Thu, 25 Sep 2008 09:29:06 -0400
- Subject: Re: patch to shrink the size of df_refs.
- References: <48DAD6E4.80604@naturalbridge.com> <48DB3867.8050602@gnu.org>
Paolo Bonzini wrote:
>> I fully tested this on ia-64 and x86-64 and compiled it on ppc-32. It
>> is quite likely that there are minor ports that contain "struct df_ref
>> *" that need to be replaced with "df_ref" which is now a typedef which
>> hides a pointer to a union or explicit accesses to fields that need to
>> now use the macros.
>>
>
> That's just mips, and it's not really minor. Can you at least make sure
> that a cross to mips-linux builds cc1?
>
> I started reviewing the patch, and there's not much to comment on. :-)
> Thanks!
>
> Paolo
>
I compiled --target=mips-unknown-elf and --target=mips-linux and this
was all that came up. I will add this to the final patch after your
comments.
kenny
Index: config/mips/mips.c
===================================================================
--- config/mips/mips.c (revision 140548)
+++ config/mips/mips.c (working copy)
@@ -12085,7 +12085,7 @@ static rtx
r10k_simplify_address (rtx x, rtx insn)
{
rtx newx, op0, op1, set, def_insn, note;
- struct df_ref *use, *def;
+ df_ref use, def;
struct df_link *defs;
newx = NULL_RTX;