This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch g++.dg/cdce3.C test for IA64 HP-UX


Richard Guenther wrote:
On Mon, Sep 22, 2008 at 1:52 AM, Xinliang David Li <davidxl@google.com> wrote:
Richard Guenther wrote:
On Sun, Sep 21, 2008 at 11:43 PM, Gerald Pfeifer <gerald@pfeifer.com>
wrote:
On Thu, 18 Sep 2008, Steve Ellcey wrote:
Right -- I saw someone added macro NO_GNU_EXTENSION to handle this.
But we shouldn't have to tell the test about each platform (darwin,
hpux, freebsd) that doesn't have pow10 individually.  The use or non-use
of -DNO_GNU_EXTENSION should be handled by a dg-require that checks for
the existence of this function.
Yes, that sounds like the right approach.  And *if* we have to specify
platforms, the default should be not to test for GNU extensions, instead
replacing

 /* { dg-options "... -DNO_GNU_EXTENSION -lm" { target "*-*-darwin*" } }
*/

by

/* { dg-options "... -DGNU_EXTENSION -lm" { target "*-*-*-gnu" } } */

or something like that.  That is, explicitly list those platforms where
these extensions will be tested.

Xinliang, is this something you could look into?

Gerald, why is freebsd returning true for large_long_double?  Does it
support long double variables but not have these particular functions?
Yes, exactly.  It seems FreeBSD 8 will be nearly complete, but not have
all of these, but released versions basically lack them.
FreeBSD rightfully also doesn't advertise TARGET_C99_FUNCTIONS - but
we don't forward this setting as a standard definition that we could test.
IMHO we should add one so we can easily skip tests that require
a (complete) C99 runtime.

Is this macro set for linux target? I tried with/without option -mglibc, it seems that macro is not set in either cases. I might have done something wrong.

It is set during GCC build only, which is why I suggest to export it to the user.

Ok. Thanks.


David


Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]