This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build
On Tue, Sep 9, 2008 at 12:32 AM, Danny Smith <dansmister@gmail.com> wrote:
> On Tue, Sep 9, 2008 at 11:16 AM, Aaron W. LaFramboise
> <aaronavay62@aaronwl.com> wrote:
>> Joseph S. Myers wrote:
>>
>>> The C front-end change is OK, but the rest will need MinGW maintainer
>>> review and the MinGW maintainers will need to judge its suitability for
>>> Stage 3.
>>
>> I recommend Danny approve this for stage 3 because this is one of the last
>> things preventing --enable-werror builds from working, which is a valuable
>> feature. It's also a bug, PR25502.
>>
>
> I really think that this is bit of an overkill and would prefer a more
> generic solution, eg fixing the bug
> "please provide a way to treat -pedantic as warning when using -Werror"
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37187
> or even including as part of -fms-extensions
>
> In other words, I am a bit concerned about adding YA MS-specific
> feature at stage 3, just to allow --enable-werror builds.
The misunderstanding here stems from the idea that this is "just to
allow --enable-werror builds." The reasoning behind the patch is that
a user of gcc on a windows based platform will legitimately want to be
able to use features of the operating system without the compiler
saying that it's wrong. The warnings that gcc outputs for the windows
platform regarding printf checking are not correct.
Shutting off all printf checking (or making all printf warnings be
handled differently regarding Werror) is a textbook case of "the baby
and the bathwater".