This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Testcases executed, even if graphite is not available
- From: Tobias Grosser <grosser at fim dot uni-passau dot de>
- To: janis187 at us dot ibm dot com
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Andrew Pinski <pinskia at gmail dot com>, Steve Kargl <sgk at troutmask dot apl dot washington dot edu>, gcc at gcc dot gnu dot org, Sebastian Pop <sebpop at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 02 Sep 2008 22:42:09 -0300
- Subject: [PATCH] Testcases executed, even if graphite is not available
- References: <20080902204940.GA90764@troutmask.apl.washington.edu> <1220389027.81857.2.camel@localhost> <Pine.LNX.4.64.0809022122240.32397@digraph.polyomino.org.uk> <1220392468.6577.18.camel@janis-laptop>
On Tue, 2008-09-02 at 14:54 -0700, Janis Johnson wrote:
> On Tue, 2008-09-02 at 21:23 +0000, Joseph S. Myers wrote:
> > On Tue, 2 Sep 2008, Andrew Pinski wrote:
> >
> > > On Tue, Sep 2, 2008 at 2:15 PM, Tobias Grosser
> > > <grosser@fim.uni-passau.de> wrote:
> > >
> > > > May be you missed to add "--with-cloog" or "--with-ppl" to
> > > > your ./configure.
> > > > Can you send me your config.log file?
> > >
> > > I thought we had decided that the build would fail to happen if the
> > > person did not have cloog and ppl installed?
> >
> > No, we decided that for 4.4 the Graphite features would be optional, with
> > errors if you use any option that would enable Graphite, *and the
> > testsuites would quietly disable all Graphite tests if Graphite support
> > was not built in*. It seems this last part is missing or buggy.
>
> Right, gfortran.dg/graphite/graphite.exp should have code like that in
> gcc.dg/graphite/graphite.exp:
>
> if ![check_effective_target_fgraphite] {
> return
> }
It seems this code is already there, but the check for
"check_effective_target_fgraphite" fails. I attached a patch. Now the
graphite test cases are only executed, if graphite is available.
See you
Tobi
2008-09-02 Tobias Grosser <grosser@fim.uni-passau.de>
* gcc/testsuite/lib/target-supports.exp
(check_effective_target_fgraphite): Fix test. Graphite is only
available with -O2.
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 527d277..9c2bb03 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -568,7 +568,7 @@ proc check_effective_target_tls_runtime {} {
proc check_effective_target_fgraphite {} {
return [check_no_compiler_messages fgraphite object {
void foo (void) { }
- } "-fgraphite"]
+ } "-O2 -fgraphite"]
}
# Return 1 if compilation with -fopenmp is error-free for trivial