This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] target/37283: Fix -fno-unit-at-a-time and ?-fno-toplevel-reorder handling
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Samuel Tardieu <sam at rfc1149 dot net>, Paul Brook <paul at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Andrew Pinski <pinskia at gmail dot com>
- Date: Tue, 02 Sep 2008 12:50:09 -0700
- Subject: Re: [PATCH] target/37283: Fix -fno-unit-at-a-time and ?-fno-toplevel-reorder handling
- References: <20080829230112.26798.87632.stgit@dawn.rfc1149.net> <de8d50360808291624s121d079fmbb80e6416a72972c@mail.gmail.com> <m3wshuz8o1.fsf@google.com>
- Reply-to: janis187 at us dot ibm dot com
On Tue, 2008-09-02 at 11:47 -0700, Ian Lance Taylor wrote:
> Janis Johnson <janis187@us.ibm.com> writes:
>
> > On Tue, 2008-09-02 at 08:04 -0700, Ian Lance Taylor wrote:
> >> Samuel Tardieu <sam@rfc1149.net> writes:
> >> > + /* We disable toplevel reordering at -O0 to disable transformations that
> >> > + might be surprising to end users and to get -fno-toplevel-reorder
> >> > + tested, but we keep section anchors. */
> >>
> >> This comment looks wrong.
> >
> > The comment was moved, and with -O0 we get no toplevel-reorder and
> > section anchors, which the following check disallows when the user
> > tries to set those explicitly.
>
> I'm not sure whether you are agreeing with my comment or disagreeing,
> but I should clarify: the comment does not describe the code to which
> it is attached.
The comment was moved and now describes the code to which it is
attached, but I think that code is wrong. It doesn't disable
section anchors for no toplevel reorder, and from what I've heard
in this group before, section anchors should be disabled with
no toplevel reorder. At least that's the case for powerpc-linux
which is now broken again for PR target/36756.
Janis