Re: New port submission - picoChip

[Hariharan <hariharans at picochip dot com>]

I have now changed the copyright notices appropriately.

Regards
Hari

Paul Brook wrote:
> On Thursday 21 August 2008, Hariharan wrote:
> > Hello ,
> > I have made further modifications to the port code and i am attaching
> > the port code and patches.
>
> I've reviewed these patches fairly extensively (and iterated internally to 
> resolve various issues).
>
> The only remaining technicality is copyright notices: 
> - Copyright notice is absent from constraints.md.
> - Most of the dates look bogus. I'm pretty sure all these files have been 
> modified this year :-)
> - The libgcc files are GPL3+exception.  My understanding is that the proper 
> wording for this has not yet been agreed, and these files should be 
> GPL2+exception.
>
> Once these are fixed the main port is, in my opinion, ready for inclusion to 
> gcc.  There's various bits[1] I'm not personally too keen on, and IMHO 
> prevent picochip become a first class gcc port. However none of these are 
> sufficient to block inclusion into gcc.
>
> The testsuite changes (patch_other) are IMHO not ready and need more work. 
> You've added lots of skips/xfails with no description of why the majority 
> have been added.
>
> Paul
>
> [1] Lack of free assembler, linker and simulator, not using ELF object files, 
> (use(const_int)) hacks, -mdebug, relying on -g -fno-omit-frame-pointer for 
> correctness and not implementing VLAs/alloca are my main gripes.

Attachment: picochip.tgz
Description: application/compressed-tar