This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Ada] PR ada/5911 Enable multilib build for Ada
- From: Laurent GUERBY <laurent at guerby dot net>
- To: Arnaud Charlet <charlet at adacore dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Paolo Bonzini <bonzini at gnu dot org>, Joel Sherrill <joel dot sherrill at oarcorp dot com>, Eric Botcazou <ebotcazou at adacore dot com>, Samuel Tardieu <sam at rfc1149 dot net>
- Date: Sun, 31 Aug 2008 18:15:25 +0200
- Subject: Re: [PATCH][Ada] PR ada/5911 Enable multilib build for Ada
- References: <1220171449.19905.106.camel@localhost> <20080831103650.GA90344@adacore.com>
On Sun, 2008-08-31 at 12:36 +0200, Arnaud Charlet wrote:
> Since builds are broken in several ways, I'd suggest waiting that things
> stabilize, otherwise people won't be able to test your change independently and
> detect related troubles easily.
Ok.
> What about make check ? Does it work now with multilibs ?
By default make check does not test multilib so no change here.
I assume some work will be needed to make gnat.dg and ACATS
aware of multilib options to make check.
> This part is OK, assuming successful powerpc testing.
Joel tested various powerpc-rtems targets with previous iterations
of this patch, I assume we'll get some new results soon.
> > 2008-08-31 Laurent Guerby <laurent@guerby.net>
> >
> > PR ada/5911
> > * gcc-interface/Makefile.in: Add multilib handling for x86_64.
>
> Please replace 'TODO' with '???' which is the convention for incomplete
> changes.
Ok will do.
> > * system-linux-sparc.ads (Storage_Unit, Word_Size, Memory_Size): Use
> > Standard attributes.
>
> This part is not OK as discussed previousely in the context of x86.
> Instead, you need to set arch appropriately, as done on x86/x86-64
Ok, I see that solaris uses system-solaris-sparcv9.ads for 64 bits
should I follow the same convention for linux?
Thanks for the quick review,
Laurent