This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Ada] PR ada/5911 Enable multilib build for Ada
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Arnaud Charlet <charlet at adacore dot com>
- Cc: Laurent GUERBY <laurent at guerby dot net>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Joel Sherrill <joel dot sherrill at oarcorp dot com>, Eric Botcazou <ebotcazou at adacore dot com>, Samuel Tardieu <sam at rfc1149 dot net>
- Date: Sun, 31 Aug 2008 14:19:26 +0200
- Subject: Re: [PATCH][Ada] PR ada/5911 Enable multilib build for Ada
- References: <1220171449.19905.106.camel@localhost> <20080831103650.GA90344@adacore.com>
> Since builds are broken in several ways, I'd suggest waiting that things
> stabilize, otherwise people won't be able to test your change independently and
> detect related troubles easily.
Agreed.
> What about make check ? Does it work now with multilibs ?
I assume only the "main" multilib is tested? No change was made here,
so this code should still apply:
# Leave this here since Ada should support multilibs at some point.
set compiler [lindex $GNAT_UNDER_TEST 0]
# if { [is_remote host] == 0 && [which $compiler] != 0 } {
# foreach i "[exec $compiler --print-multi-lib]" {
# set mldir ""
# regexp -- "\[a-z0-9=/\.-\]*;" $i mldir
# set mldir [string trimright $mldir "\;@"]
# if { "$mldir" == "." } {
# continue
# }
# if { [llength [glob -nocomplain
${rootme}/${mldir}/libgcc_s*.so.*]] >= 1 } {
# append gnat_libgcc_s_path ":${rootme}/${mldir}"
# }
# }
# }
Maybe however the first comment should be updated.
>> 2008-08-31 Laurent Guerby <laurent@guerby.net>
>> Paolo Bonzini <bonzini@gnu.org>
>>
>> PR ada/5911
>> * Makefile.in (all, install, mostlyclean, clean, distclean): Add
>> multilib handling.
>> * configure.ac: Add multilib handling.
>> * configure: Regenerate.
>
> This part is OK, assuming successful powerpc testing.
I think Joel will take care of testing. In particular he had trouble
with m68k which should be fixed now (because as part of the cleanups I
made at the beginning of August, libada does not anymore include target
fragments from gcc/config).
Paolo