This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR middle-end/37269: extract_bit_field_1 doesn't handle vector mode properly

On Thu, Aug 28, 2008 at 2:37 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Thu, Aug 28, 2008 at 2:32 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
>> But my version generates shorter code on my testcase. I will
>> compare your testcase on x86.
>
> Well it might generate smaller code but I think there is a missing
> optimization.  I think generic vector operands expand to use
> BIT_FIELD_REF instead of producing an array which is used for the
> extraction at that point which produces worse code in some cases, see
> PR 28366.  So my patch is correct, just we are missing out because of
> the generic vector operators expansion is doing something that
> produces worse code in the first place.
>

Yes, your patch is better. Can you include my testcase for PR37269 in
your patch for PR 36444?

Thanks.

-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]