This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] limit commit message to 500 lines (was: Please, do not use the merged revisions log as the commit message when merging)
- From: "Manuel López-Ibáñez" <lopezibanez at gmail dot com>
- To: "Laurent GUERBY" <laurent at guerby dot net>, "Gcc Patch List" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 26 Aug 2008 18:19:36 +0200
- Subject: Re: [PATCH] limit commit message to 500 lines (was: Please, do not use the merged revisions log as the commit message when merging)
- References: <6c33472e0808260718v281cff7en1dcc6ec54cdfdcc9@mail.gmail.com> <1219764262.13055.58.camel@localhost>
Of 139510 commits, only 12 have more than 500 lines and only 9 have
more than 700. There are two with more than 1000 lines.
r136433 | jakub | 2008-06-06 15:01:54 +0200 (Fri, 06 Jun 2008) | 889 lines
r122168 | bkoz | 2007-02-20 19:15:01 +0100 (Tue, 20 Feb 2007) | 920 lines
r122018 | sandra | 2007-02-16 00:50:49 +0100 (Fri, 16 Feb 2007) | 862 lines
r114659 | bkoz | 2006-06-15 01:09:51 +0200 (Thu, 15 Jun 2006) | 878 lines
r108152 | rsandifo | 2005-12-07 08:53:14 +0100 (Wed, 07 Dec 2005) | 500 lines
r95152 | mkoch | 2005-02-17 08:48:58 +0100 (Thu, 17 Feb 2005) | 616 lines
r95115 | graydon | 2005-02-16 21:03:29 +0100 (Wed, 16 Feb 2005) | 1998 lines
r82314 | graydon | 2004-05-27 08:17:44 +0200 (Thu, 27 May 2004) | 556 lines
r79607 | graydon | 2004-03-17 22:29:02 +0100 (Wed, 17 Mar 2004) | 578 lines
r76701 | amylaar | 2004-01-27 13:49:31 +0100 (Tue, 27 Jan 2004) | 2915 lines
r55189 | amylaar | 2002-07-02 20:45:49 +0200 (Tue, 02 Jul 2002) | 684 lines
r43861 | kenner | 2001-07-09 13:20:51 +0200 (Mon, 09 Jul 2001) | 980 lines
Anyone can disable the hook script for special cases (it is versioned
after all just "svn co svn+ssh://gcc.gnu.org/svn/gcc/hooks").
Cheers,
Manuel
2008/8/26 Laurent GUERBY <laurent@guerby.net>:
> Out of curiosity did you do a batch scan of existing ChangeLog
> files to see how many entries are above your choosen limit of 500 lines?
>
> Laurent
>
> On Tue, 2008-08-26 at 16:18 +0200, Manuel López-Ibáñez wrote:
>> 2008/8/16 Manuel López-Ibáñez <lopezibanez@gmail.com>:
>> > Could we put a limit to the commit log entry? More than 500 hundred
>> > lines changelog entries should just be rejected and this will avoid
>> > someone accidentally committing a full log or a diff or just random
>> > junk.
>> >
>>
>> The following patch to our pre-commit hook enables this. I have tested
>> it with a dummy repository but review from bourne-shell and/or
>> subversion knowledgeable people would be welcome.
>>
>> Who can approve this?
>>
>> Cheers,
>>
>> Manuel.
>
>