This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Updated IPCP cost model
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 26 Aug 2008 10:21:55 +0200
- Subject: Re: Updated IPCP cost model
- References: <20080824175518.GC9952@kam.mff.cuni.cz>
Hello,
a couple of nits:
* Jan Hubicka wrote on Sun, Aug 24, 2008 at 07:55:18PM CEST:
> *** doc/invoke.texi (revision 139536)
> --- doc/invoke.texi (working copy)
> ! @item -fipa-cp-clone
> ! @opindex fipa-cp-clone
> ! Perform function clonning to make interprocedural constant propagation stronger.
s/clonning/cloning/ ?
Several instances in the patch, also in code.
I'd write "to strengthen ..." instead of "to make ... stronger".
> ! When enabled, interprocedural constant propagation will perform function clonning
> ! when externally visible function can be called with constant arguments.
> ! Because this optimization can create multiple copies of functions,
> ! it may significantly increase code size
> ! (see @option{--param ipcp-unit-growth=@var{value}}).
>
> *** ipa-cp.c (revision 139536)
> --- ipa-cp.c (working copy)
> *************** along with GCC; see the file COPYING3.
> *** 132,137 ****
> --- 132,139 ----
> #include "diagnostic.h"
> #include "tree-dump.h"
> #include "tree-inline.h"
> + #include "fibheap.h"
> + #include "params.h"
This needs adjustment of the makefile dependencies.
Cheers,
Ralf